Notify users when Liquid files are rewritten remotely #6739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/snapit |
aswamy
force-pushed
the
01-02-notify_users_when_liquid_files_are_rewritten_remotely
branch
from
fa04b0c to
09881b1
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/cli/api/graphql/admin/generated/theme_files_upsert.d.ts@@ -8,6 +8,7 @@ export type ThemeFilesUpsertMutation = {
themeFilesUpsert?: {
upsertedThemeFiles?: {
filename: string;
+ checksumMd5?: string | null;
}[] | null;
userErrors: {
filename?: string | null;
|
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3589 tests passing in 1420 suites. Report generated by 🧪jest coverage report action from 09881b1 |
Contributor
Author
|
/snapit |
Contributor
Author
|
Going with an alternate approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This PR was previously introduced but contained a bug on Windows: #6524. The bug was found and is patched in this PR.
WHAT is this pull request doing?
shopify theme pushorshopify theme dev, you are notified when the liquid files contains bad liquid codeNOTE: If we also rewrite for
shopify app pushandshopify app devwe should also update it there 🤔How to test your changes?
{% for i in (1.....5) %}{% endfor %}shopify theme pushand notice a message saying it was updated remotelyshopify theme devinsteadshopify theme devis running, it will say in the logs that the file was overwrittenPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist